both of us had hit the accept button. I logged out 20 seconds later and so it seems the inventory exchange request must have been cancelled. This needs to be transactional so that that can't fail. My logging out should not have prevented that transaction completing after both had hit accept. At this point it should be final. the transaction for things like this should kick off a work unit on the server that is independant of the client request so anything happening to the client such as a disconnect cannot affect it.

However even if that is affecting it, it should still be a safe transaction, both items should be removed from each others inventory and moved to the other within one DB transaction so if anything fails both parts of the transaction fail. This therefore highlights a problem with the DB logic for the trade window.

This isn't to mention how many times the trade window doesn't work properly such as when other items overlap such as the other chrs name which prevents you clicking on another window such as the trade window or hitting the accept button.